Order XCom entries by map index in API #37086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
requested review from
ephraimbuddy and
pierrejeambrun
as code owners
ephraimbuddy
approved these changes
Jan 30, 2024
uranusjr
commented
Jan 30, 2024
This makes the resulting list more stable.
uranusjr
force-pushed
the
flaky-xcom-api
branch
from
162bbb5
to
b52e699
Compare
potiuk
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the resulting list more stable.
I found this in a failed CI run: https://github.com/apache/airflow/actions/runs/7698956149/job/20980348665
While it is technically possible to just fix this in the tests, I feel it is better to make the list returned by the API have a stable ordering since this is useful in general anyway.