Bugfix Triggering DAG with parameters is mandatory when show_trigger_form_if_no_params is enabled #37063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jscheffl
added
type:bug-fix
jscheffl
requested review from
ryanahamilton,
ashb,
bbovenzi and
pierrejeambrun
as code owners
jscheffl
changed the title
hussein-awala
approved these changes
Jan 29, 2024
potiuk
approved these changes
Jan 29, 2024
Closed
2 tasks
68 tasks
2 tasks
abhishekbhakat
pushed a commit
to abhishekbhakat/my_airflow
that referenced
this pull request
Mar 5, 2024
…form_if_no_params is enabled (apache#37063) * Add a requested default configuration to form call to start w/o form display * Follow-up bugfix - ensure bad form values are transferred when key exists
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the last rework of the trigger form to prevent a XSS we did not fully test the UI when the configuration
show_trigger_form_if_no_paramsis set to True.This PR fixes the reported problem as reported in #36843 by submitting a virtual empty form.
Alongside I found that there is a key error if some required fields are not set, which still is validated. In such cases an Exception was produced earlier, now it is correctly forwarding and forcing the user to enter data into the form.
How to test (needs to be made manually :-( ):
AIRFLOW__WEBSERVER__SHOW_TRIGGER_FORM_IF_NO_PARAMS=Trueand try to start the two DAGs above with and without params. Shuod fix the bug reported.closes: #36843