Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dataset support to objectstorage #36947

Merged
merged 2 commits into from
Jan 23, 2024

Conversation

bolkedebruin
Copy link
Contributor

This means you can now do ObjectStoragePath(a_dataset)


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

This means you can now do ObjectStoragePath(a_dataset)
Copy link
Member

@hussein-awala hussein-awala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM

airflow/io/path.py Outdated Show resolved Hide resolved
@bolkedebruin bolkedebruin added this to the Airflow 2.8.2 milestone Jan 23, 2024
@bolkedebruin bolkedebruin merged commit f3b7cfc into apache:main Jan 23, 2024
56 checks passed
@bolkedebruin bolkedebruin deleted the dataset_path branch January 23, 2024 13:51
@jedcunningham jedcunningham added the type:improvement Changelog: Improvements label Feb 5, 2024
@jedcunningham
Copy link
Member

(@bolkedebruin, also moving this to 2.9)

abhishekbhakat pushed a commit to abhishekbhakat/my_airflow that referenced this pull request Mar 5, 2024
This makes datasets inherit from os.Pathlike so they can directly be used by
the Object Storage API.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:improvement Changelog: Improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants