-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve ExternalTaskSensor Async Implementation #36916
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:core-operators
Operators, Sensors and hooks within Core Airflow
area:Triggerer
labels
Jan 19, 2024
Taragolis
reviewed
Jan 19, 2024
phanikumv
reviewed
Jan 22, 2024
Lee-W
reviewed
Jan 22, 2024
eladkal
reviewed
Jan 23, 2024
3 tasks
Lee-W
reviewed
Jan 25, 2024
pankajastro
force-pushed
the
fix_external_sensor
branch
from
January 25, 2024 08:24
b274f8b
to
5c1c01a
Compare
phanikumv
approved these changes
Jan 25, 2024
amoghrajesh
pushed a commit
to amoghrajesh/airflow
that referenced
this pull request
Jan 30, 2024
This was referenced Feb 26, 2024
abhishekbhakat
pushed a commit
to abhishekbhakat/my_airflow
that referenced
this pull request
Mar 5, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:core-operators
Operators, Sensors and hooks within Core Airflow
area:Triggerer
type:improvement
Changelog: Improvements
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses several differences between the synchronous and asynchronous implementations of ExternalTaskSensor. The changes include:
Soft Failure Handling:
Monitoring Multiple Tasks, Task Groups, and DAGs:
Code Organization:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.