-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix assignment of template field in __init__
in CloudDataTransferServiceCreateJobOperator
#36909
Merged
hussein-awala
merged 4 commits into
apache:main
from
romsharon98:fix/cloud-storage-transfer-service
Feb 4, 2024
Merged
Fix assignment of template field in __init__
in CloudDataTransferServiceCreateJobOperator
#36909
hussein-awala
merged 4 commits into
apache:main
from
romsharon98:fix/cloud-storage-transfer-service
Feb 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:google
Google (including GCP) related issues
labels
Jan 19, 2024
dirrao
reviewed
Jan 19, 2024
airflow/providers/google/cloud/operators/cloud_storage_transfer_service.py
Show resolved
Hide resolved
romsharon98
force-pushed
the
fix/cloud-storage-transfer-service
branch
from
January 20, 2024 19:18
dfc0edf
to
ac95f65
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to add a test for str body?
romsharon98
force-pushed
the
fix/cloud-storage-transfer-service
branch
from
January 21, 2024 16:29
ac95f65
to
d77f115
Compare
Added 👍 |
eladkal
approved these changes
Jan 21, 2024
tests/providers/google/cloud/operators/test_cloud_storage_transfer_service.py
Outdated
Show resolved
Hide resolved
romsharon98
force-pushed
the
fix/cloud-storage-transfer-service
branch
from
February 4, 2024 11:01
f1468ee
to
2896623
Compare
hussein-awala
approved these changes
Feb 4, 2024
81 tasks
27 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #36484
fix:
cc: @shahar1
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.