-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Callback exception when a removed task is the last one in the task instance list #36693
Merged
ephraimbuddy
merged 11 commits into
apache:main
from
joaopamaral:fix/handle_callback_with_removed_task
Jan 15, 2024
Merged
Fix Callback exception when a removed task is the last one in the task instance list #36693
ephraimbuddy
merged 11 commits into
apache:main
from
joaopamaral:fix/handle_callback_with_removed_task
Jan 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a test for your change?
…moved_task' into fix/handle_callback_with_removed_task
eladkal
added
type:bug-fix
Changelog: Bug Fixes
and removed
kind:bug
This is a clearly a bug
labels
Jan 10, 2024
vincbeck
approved these changes
Jan 11, 2024
ephraimbuddy
requested changes
Jan 12, 2024
Tests are failing |
ephraimbuddy
approved these changes
Jan 15, 2024
68 tasks
abhishekbhakat
pushed a commit
to abhishekbhakat/my_airflow
that referenced
this pull request
Mar 5, 2024
…k instance list (apache#36693) * Fix Callback exception when a removed task is the last one in the task instance list * Add test_dag_handle_callback_with_removed_task * Remove extra break line * Merge TIs filters * Fix static check * Revert changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a task is removed and is returned in the last position of
get_task_instances
, the callback request will fail because it will try to access this task, but it doesn't exist anymore.To fix it we are filtering out the removed tasks to avoid having a removed task in the last position again.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.