-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flake8-implicit-str-concat check to Ruff #36597
Conversation
Other than one comment, looks good to me! Love this one ❤️ |
Likewise :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, just wondering how those string concatenations existed in so many places :) maybe it was another pre-commit responsible for it.
We used to get rid of them by flake I think - but at the time we moved to ruff it was not available as far as I remember. That's the root cause we had so many of those. And yes. I got far too many of those as well and it started to be annoying :) |
This was enabled initially in apache#23873, but hasn't been part of the Ruff checks to-date. Let's add it!
This check was enabled initially in #23873, but hasn't been part of the Ruff checks to-date. Let's add it!