Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add use_regex argument for allowing S3KeySensor to check s3 keys with regular expression #36578

Merged
merged 5 commits into from
Jan 10, 2024

Conversation

Lee-W
Copy link
Member

@Lee-W Lee-W commented Jan 4, 2024


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:providers provider:amazon-aws AWS/Amazon - related issues labels Jan 4, 2024
@Lee-W Lee-W force-pushed the add-use-regex-to-S3KeySensor branch 2 times, most recently from 796494b to ef390d8 Compare January 4, 2024 09:52
Copy link
Contributor

@dirrao dirrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great if we can add the test cases for the regex.

@Lee-W
Copy link
Member Author

Lee-W commented Jan 4, 2024

It would be great if we can add the test cases for the regex.

Yep, will do. Thanks for suggestion 😄

@Lee-W Lee-W force-pushed the add-use-regex-to-S3KeySensor branch from 2bce5f0 to 76eb51a Compare January 8, 2024 09:25
@Lee-W Lee-W marked this pull request as ready for review January 8, 2024 09:27
@Lee-W Lee-W changed the title add use_regex to S3KeySensor add use_regex for allowing S3KeySensor to check with regular expression Jan 8, 2024
@Lee-W Lee-W changed the title add use_regex for allowing S3KeySensor to check with regular expression add use_regex argument for allowing S3KeySensor to check with regular expression Jan 8, 2024
@Lee-W Lee-W changed the title add use_regex argument for allowing S3KeySensor to check with regular expression add use_regex argument for allowing S3KeySensor to check s3 keys with regular expression Jan 8, 2024
@Lee-W Lee-W force-pushed the add-use-regex-to-S3KeySensor branch 2 times, most recently from b465528 to c005bff Compare January 8, 2024 10:06
Copy link
Contributor

@vincbeck vincbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a cool feature users might be interested in. I think it is worth mentioning it in docs?

@Lee-W Lee-W force-pushed the add-use-regex-to-S3KeySensor branch from c005bff to a459a42 Compare January 9, 2024 04:01
@vincbeck vincbeck merged commit 9f04716 into apache:main Jan 10, 2024
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:amazon-aws AWS/Amazon - related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants