-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit pod_name length to HOST_NAME_MAX #36332
Conversation
0821ff8
to
72022f4
Compare
5b3c57c
to
f71207f
Compare
How do you plan to tackle backwards compatibilty. Imagine you are upgrading Airflow and thera are long running Pods still running being adopted by the new Airflow with limited length/ What is your plan to do with it? |
Pod adoption is seamless. As we are not using pod name to deduce anything. Its just a reference to identify the dag and task from pod while debugging. |
@csp33 |
f71207f
to
c547b16
Compare
K8s executor does not use the pod name to adopt previous TIs, it uses the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work. LGTM.
Cool |
c547b16
to
aa80afd
Compare
Closes #36326