-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support mysql backend as keda trigger #36167
feat: support mysql backend as keda trigger #36167
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
b71e8af
to
b51251a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add tests for mounted secret, kedaConnection value, and KEDA scaler when the protocol is MySQL?
Yes, Sure :) |
622e73e
to
19d8afd
Compare
419e76c
to
d6ecfca
Compare
Hi @hussein-awala, Happy new year :) Is the changes fine to you ? Thanks |
cf2c722
to
a66df59
Compare
5dd4094
to
2c0cce9
Compare
static checks are failing |
apache#36166 Signed-off-by: Romain Forlot <[email protected]>
Thanks @hussein-awala for review Signed-off-by: Romain Forlot <[email protected]>
Testing that required key are present for the trigger definition and at the right value Signed-off-by: Romain Forlot <[email protected]>
2c0cce9
to
53f84fa
Compare
Signed-off-by: Romain Forlot <[email protected]>
@eladkal Sure, I update the PR to make it pass. |
@claneys static tests are failing |
Signed-off-by: Romain Forlot <[email protected]>
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
Closes: #36166
Airflow currently support two SQL database backend with postgresql and mysql. PostgreSQL being the default one it's also the trigger used by default by the Keda ScaledObject created when enabling autoscaling. Which do not work if using a mysql database. Query has to be changed a bit and mysql trigger parameters aren't the same (pretty sneaky little changes within key names) and most of all the connection string used isn't the correct one when addressing to mysql.