Add scripts\in_container folder when all other sources are removed.
#36129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
force-pushed
the
improve-debugging-for-in-container-scripts
branch
from
5fb7483 to
eb97e1d
Compare
potiuk
force-pushed
the
improve-debugging-for-in-container-scripts
branch
from
eb97e1d to
8b250b8
Compare
potiuk
changed the title
scripts folder when generally all other sources are removed.scripts\in_container folder when all other sources are removed.
potiuk
force-pushed
the
improve-debugging-for-in-container-scripts
branch
from
8b250b8 to
9365a35
Compare
eladkal
approved these changes
Dec 8, 2023
This allows to tests the scripts that require --mount-sources remove but you run some scripts inside the container (for example this was the case when modifying installation of airflow and providers to be run in Python in apache#36094. In order to debug those, The image needed to be rebuild to run the "in-container" scripts.. More importantly - users will also have to rebuild the image after they rebase to latest main - in order to use the new scripts when runinng `--use-airflow-version`. This change will make the modification coming from main visible in their images even without rebuilding the image.
potiuk
force-pushed
the
improve-debugging-for-in-container-scripts
branch
from
9365a35 to
be90bb8
Compare
vincbeck
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to tests the scripts that require --mount-sources remove but you run some scripts inside the container (for example this was the case when modifying installation of airflow and providers to be run in Python in #36094. In order to debug those, image needed to be rebuild to run the "in-container" scripts..
More importantly - users will also have to rebuild the image after they rebase to latest main - in order to use the new scripts when runinng
--use-airflow-version.This change will make the modification coming from main visible in
their images even without rebuilding the image.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.