Create directories based on AIRFLOW_CONFIG path
#35818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taragolis
requested review from
potiuk,
uranusjr,
hussein-awala,
eladkal and
vincbeck
vincbeck
approved these changes
Nov 23, 2023
|
Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
write_default_airflow_configuration_if_neededcreate Airflow Home directory, which should work in case if user doesn't redefineAIRFLOW_CONFIGenvironment variable.This PR focus to create directories to
AIRFLOW_CONFIGbut only in case if path relative toAIRFLOW_HOMEotherwise it will raise an error, e.g. airflow home =/opt/airflow/and airflow_config refers to/root/config/foo.cfgAlso check that
AIRFLOW_CONFIGis not a directory, e.g. avoid situation miss configuration to "${AIRFLOW_CONFIG}/config/"^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.