openlineage, aws: add OpenLineage support for Redshift SQL. #35794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:amazon-aws
|
@ferruzzi, you might be interested into this one :) |
o-nikolas
reviewed
Nov 22, 2023
ferruzzi
reviewed
Nov 22, 2023
ferruzzi
reviewed
Dec 7, 2023
JDarDagran
force-pushed
the
openlineage/add-redshift-sql-support
branch
from
9140ea8 to
9bffe5c
Compare
|
Still waiting to resolve the conversation with Niko but other than that discussion, the rest LGTM |
|
Pinging @o-nikolas then :) |
Add flat information schema query support in SQLParser. Signed-off-by: Jakub Dardzinski <[email protected]>
JDarDagran
force-pushed
the
openlineage/add-redshift-sql-support
branch
from
9bffe5c to
bedcba1
Compare
|
@ferruzzi it seems we're ready to go? |
|
@ferruzzi @o-nikolas the PR is hanging for quite a long time. Is there anything in particular that would need explanation or any action? |
o-nikolas
approved these changes
Jan 4, 2024
Dennis gave a LGTM in a previous comment, so I approved and merged with two approvals :) |
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add flat information schema query support in SQLParser.
This PR adds support for Redshift SQL.
Additional changes in OpenLineage SQL utils were neccessary. This is because Redshift has capability to make cross-database queries, however, traditional cross-database queries to
information_schema.columnsdoes not work. Instead one should read fromSVV_REDSHIFT_COLUMNSwhich is a single table containing multi-database information.