Add missing docker test_exceptions.py

[rpkay]

This PR adds a simple test for docker exceptions (DockerContainerFailedException, DockerContainerFailedSkipException)

Part of #35442

---

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

[boring-cyborg]

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

• Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
• In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
• Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
• Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
• Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
• Be sure to read the Airflow Coding style.
• Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
  Apache Airflow is a community-driven project and together we are making it better 🚀.
  In case of doubts contact the developers at:
  Mailing List: [email protected]
  Slack: https://s.apache.org/airflow-slack

[Lee-W]

I'm not sure these tests really check much. I might suggest adding tests to this block

airflow/airflow/providers/docker/operators/docker.py

Lines 432 to 437 in 9103ea1

	if result["StatusCode"] in self.skip_on_exit_code:
	raise DockerContainerFailedSkipException(
	f"Docker container returned exit code {self.skip_on_exit_code}. Skipping.", logs=log_lines
	)
	elif result["StatusCode"] != 0:
	raise DockerContainerFailedException(f"Docker container failed: {result!r}", logs=log_lines)

[rpkay]

I'm not sure these tests really check much. I might suggest adding tests to this block

airflow/airflow/providers/docker/operators/docker.py

Lines 432 to 437 in 9103ea1

	if result["StatusCode"] in self.skip_on_exit_code:
	raise DockerContainerFailedSkipException(
	f"Docker container returned exit code {self.skip_on_exit_code}. Skipping.", logs=log_lines
	)
	elif result["StatusCode"] != 0:
	raise DockerContainerFailedException(f"Docker container failed: {result!r}", logs=log_lines)

I am not sure if I understood your comment, can you please give some detail if possible ?

[Lee-W]

I'm not sure these tests really check much. I might suggest adding tests to this block

airflow/airflow/providers/docker/operators/docker.py

Lines 432 to 437 in 9103ea1

	if result["StatusCode"] in self.skip_on_exit_code:
	raise DockerContainerFailedSkipException(
	f"Docker container returned exit code {self.skip_on_exit_code}. Skipping.", logs=log_lines
	)
	elif result["StatusCode"] != 0:
	raise DockerContainerFailedException(f"Docker container failed: {result!r}", logs=log_lines)

I am not sure if I understood your comment, can you please give some detail if possible ?

It seems to me that the test we're having in this PR might not actually test meaningful things. So, if we're to add tests to cover the exception, maybe the code block I pasted could be a choice

[rpkay]

I'm not sure these tests really check much. I might suggest adding tests to this block

airflow/airflow/providers/docker/operators/docker.py

Lines 432 to 437 in 9103ea1

	if result["StatusCode"] in self.skip_on_exit_code:
	raise DockerContainerFailedSkipException(
	f"Docker container returned exit code {self.skip_on_exit_code}. Skipping.", logs=log_lines
	)
	elif result["StatusCode"] != 0:
	raise DockerContainerFailedException(f"Docker container failed: {result!r}", logs=log_lines)

I am not sure if I understood your comment, can you please give some detail if possible ?

It seems to me that the test we're having in this PR might not actually test meaningful things. So, if we're to add tests to cover the exception, maybe the code block I pasted could be a choice

Thank you for the clarification, I will work on the change.

[potiuk]

@Lee-W ? Are you happy ?

[Lee-W]

Hi all, sorry for the late review. Wasn't feeling well lately. let me review it now

[Lee-W]

Looks awesome! @rpkay Thanks for your great work!

[boring-cyborg]

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

[rpkay]

Thank you @Lee-W for your guidance.

Special thanks to @Taragolis for code reference.