Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comment for elasticsearch connection schema #35588

Merged
merged 1 commit into from
Nov 12, 2023

Conversation

romsharon98
Copy link
Contributor

It's not a straight forward that the schema is changeable.
I needed to check the elasticsearch-secret for knowing schema is a part of connection and then changed it to https.
Thought it will be nicer for the user to know that schema is under connection.

@boring-cyborg boring-cyborg bot added the area:helm-chart Airflow Helm Chart label Nov 12, 2023
@romsharon98 romsharon98 changed the title add comment for schema Add comment for elasticsearch connection schema Nov 12, 2023
@potiuk potiuk merged commit 938885f into apache:main Nov 12, 2023
55 checks passed
@eladkal eladkal added this to the Airflow Helm Chart 1.12.0 milestone Nov 12, 2023
@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:helm-chart Airflow Helm Chart changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants