-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add templating for PVC storageClassName #35581
Merged
eladkal
merged 14 commits into
apache:main
from
romsharon98:feature/fixed_templated_storage_class
Nov 12, 2023
Merged
Feature/add templating for PVC storageClassName #35581
eladkal
merged 14 commits into
apache:main
from
romsharon98:feature/fixed_templated_storage_class
Nov 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romsharon98
requested review from
dstandish,
jedcunningham and
hussein-awala
as code owners
November 11, 2023 09:05
romsharon98
changed the title
Feature/fixed templated storage class
Feature/add templating for PVC storageClassName
Nov 11, 2023
* chore(helm): safer worker pod annotations * chore(helm): safer worker pod annotations --------- Co-authored-by: hakuno <[email protected]> Co-authored-by: Hussein Awala <[email protected]>
romsharon98
force-pushed
the
feature/fixed_templated_storage_class
branch
from
November 11, 2023 16:10
2e09637
to
d21c3b6
Compare
hussein-awala
approved these changes
Nov 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
eladkal
approved these changes
Nov 12, 2023
ephraimbuddy
added
the
changelog:skip
Changes that should be skipped from the changelog (CI, tests, etc..)
label
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:helm-chart
Airflow Helm Chart
changelog:skip
Changes that should be skipped from the changelog (CI, tests, etc..)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add templating for storageClassName in persistent volume claim
fixes: #32581