Fix: Paginate on lastest Response #35560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
60 tasks
Joffreybvn
commented
Nov 10, 2023
| while True: | ||
| next_page_params = self.pagination_function(first_response) | ||
| next_page_params = self.pagination_function(response) | ||
| if not next_page_params: | ||
| break | ||
| response = self.hook.run(**self._merge_next_page_parameters(next_page_params)) |
There was a problem hiding this comment.
If I'm not mistaken, your change just renames the method
paginate_syncfirst_responseparam toresponse, how does this fix the bug?
Lines 177/178 set the response to a response variable.
With this PR, the response is correctly reattributed and reach the pagination_function. Previously, the pagination function was repeatedly called with the first_response, which never changes.
There was a problem hiding this comment.
Ah yes, the response value is updated after each iteration
Joffreybvn
force-pushed
the
fix/paginate-on-last-response
branch
from
b05a84d to
a670e3c
Compare
hussein-awala
approved these changes
Nov 10, 2023
| while True: | ||
| next_page_params = self.pagination_function(first_response) | ||
| next_page_params = self.pagination_function(response) | ||
| if not next_page_params: | ||
| break | ||
| response = self.hook.run(**self._merge_next_page_parameters(next_page_params)) |
There was a problem hiding this comment.
Ah yes, the response value is updated after each iteration
eladkal
approved these changes
Nov 11, 2023
5 tasks
ephraimbuddy
added
the
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new pagination functionality of the
HttpOperatordo not work as expected when non-deferred:If should pass the latest response to the pagination_function, instead of always passing the very first response.
This PR clarify and fix this behavior.
Apologize for this. Between all the changes in the initial PR, I overlooked this issue, and my initial test was not strong enough to highlight it. Will definitively take more care !
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.