Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ECS Executor to its own file #35418

Merged

Conversation

syedahsn
Copy link
Contributor

@syedahsn syedahsn commented Nov 3, 2023

Move ECS Executor from __init__.py to its own file. This improves the logging because logs record the filename, and __init__.py was not a helpful name.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

… logging because logs record the filename, and __init__.py was not a helpful name.
@potiuk potiuk merged commit 92d1e8c into apache:main Nov 3, 2023
45 checks passed
@o-nikolas
Copy link
Contributor

Niko goes off to rebase his PR 😅

romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Nov 10, 2023
* Move ECS Executor from __init__.py to its own file. This improves the logging because logs record the filename, and __init__.py was not a helpful name.

* Fix failing tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants