-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pgvector provider implementation #35399
Conversation
0f08392
to
8960739
Compare
8960739
to
74bc354
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@utkarsharma2 we have security.rst in other provider docs. example: https://github.com/apache/airflow/blob/main/docs/apache-airflow-providers-apache-cassandra/security.rst do we need to add this here too?
Yes. This file is generated automatically when publishing documentation (because soon we will start generating SBOM information there automatically), but it's good to add it. |
(we will improve that part when we automate SBOM publishing). |
89d2187
to
ccf29f9
Compare
ccf29f9
to
ad0e202
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please rebase this see #34921 (comment)
0ec1705
to
4361b08
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, it looks great :)
Left a few minor suggestions
- missing type annotation
- using f-string instead of string concatenation
7ba1ec5
to
c88abdc
Compare
Co-authored-by: Pankaj Singh <[email protected]>
Co-authored-by: Wei Lee <[email protected]>
c88abdc
to
164880c
Compare
Hmm wait! Some of Build CI images step errored/failed, how did other tests succeed! @pankajkoti You might need to keep close eyes on the running tests in main. And revert or quick fix things if they fail |
This was unrelated though (bullseye -> bookworm) and fixed here: #35503 |
It should not impact overal "health" of the PR. |
This PR is part of our larger effort to add first-class integrations to support LLMOps that was [presented at Airflow Summit](https://www.youtube.com/watch?v=mgA6m3ggKhs&t=4s). This PR adds explicitly the pgvector Provider. https://github.com/pgvector/pgvector Email Discussion related to the effort can be found here - https://lists.apache.org/thread/0d669fmy4hn29h5c0wj0ottdskd77ktp
This PR is part of our larger effort to add first-class integrations to support LLMOps that was presented at Airflow Summit.
This PR adds explicitly the pgvector Provider.
https://github.com/pgvector/pgvector
Email Discussion related to the effort can be found here - https://lists.apache.org/thread/0d669fmy4hn29h5c0wj0ottdskd77ktp
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.