Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pgvector provider implementation #35399

Merged
merged 13 commits into from
Nov 7, 2023

Conversation

pankajkoti
Copy link
Member

@pankajkoti pankajkoti commented Nov 3, 2023

This PR is part of our larger effort to add first-class integrations to support LLMOps that was presented at Airflow Summit.

This PR adds explicitly the pgvector Provider.
https://github.com/pgvector/pgvector

Email Discussion related to the effort can be found here - https://lists.apache.org/thread/0d669fmy4hn29h5c0wj0ottdskd77ktp


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Copy link
Member

@pankajastro pankajastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@utkarsharma2 we have security.rst in other provider docs. example: https://github.com/apache/airflow/blob/main/docs/apache-airflow-providers-apache-cassandra/security.rst do we need to add this here too?

@potiuk
Copy link
Member

potiuk commented Nov 3, 2023

@utkarsharma2 we have security.rst in other provider docs. example: https://github.com/apache/airflow/blob/main/docs/apache-airflow-providers-apache-cassandra/security.rst do we need to add this here too?

Yes. This file is generated automatically when publishing documentation (because soon we will start generating SBOM information there automatically), but it's good to add it.

@potiuk
Copy link
Member

potiuk commented Nov 3, 2023

(we will improve that part when we automate SBOM publishing).

@pankajkoti pankajkoti force-pushed the add-pgvector-provider branch from 89d2187 to ccf29f9 Compare November 4, 2023 04:57
@pankajkoti pankajkoti force-pushed the add-pgvector-provider branch from ccf29f9 to ad0e202 Compare November 4, 2023 05:03
Copy link
Member

@pankajastro pankajastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please rebase this see #34921 (comment)

docs/apache-airflow-providers-pgvector/security.rst Outdated Show resolved Hide resolved
Copy link
Member

@Lee-W Lee-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, it looks great :)

Left a few minor suggestions

  1. missing type annotation
  2. using f-string instead of string concatenation

airflow/providers/pgvector/hooks/pgvector.py Outdated Show resolved Hide resolved
airflow/providers/pgvector/hooks/pgvector.py Outdated Show resolved Hide resolved
airflow/providers/pgvector/hooks/pgvector.py Outdated Show resolved Hide resolved
airflow/providers/pgvector/hooks/pgvector.py Outdated Show resolved Hide resolved
airflow/providers/pgvector/hooks/pgvector.py Outdated Show resolved Hide resolved
airflow/providers/pgvector/hooks/pgvector.py Outdated Show resolved Hide resolved
airflow/providers/pgvector/hooks/pgvector.py Outdated Show resolved Hide resolved
airflow/providers/pgvector/operators/pgvector.py Outdated Show resolved Hide resolved
airflow/providers/pgvector/operators/pgvector.py Outdated Show resolved Hide resolved
@pankajkoti pankajkoti force-pushed the add-pgvector-provider branch from 7ba1ec5 to c88abdc Compare November 6, 2023 19:21
@pankajkoti pankajkoti force-pushed the add-pgvector-provider branch from c88abdc to 164880c Compare November 7, 2023 09:26
@pankajkoti pankajkoti closed this Nov 7, 2023
@pankajkoti pankajkoti reopened this Nov 7, 2023
@pankajkoti pankajkoti added the use public runners Makes sure that Public runners are used even if commiters creates the PR (useful for testing) label Nov 7, 2023
@pankajkoti pankajkoti closed this Nov 7, 2023
@pankajkoti pankajkoti reopened this Nov 7, 2023
@kaxil kaxil merged commit fb76f1f into apache:main Nov 7, 2023
73 of 154 checks passed
@kaxil kaxil deleted the add-pgvector-provider branch November 7, 2023 13:10
@kaxil
Copy link
Member

kaxil commented Nov 7, 2023

Hmm wait! Some of Build CI images step errored/failed, how did other tests succeed!

@pankajkoti You might need to keep close eyes on the running tests in main. And revert or quick fix things if they fail

@potiuk
Copy link
Member

potiuk commented Nov 7, 2023

This was unrelated though (bullseye -> bookworm) and fixed here: #35503

@potiuk
Copy link
Member

potiuk commented Nov 7, 2023

It should not impact overal "health" of the PR.

romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Nov 10, 2023
This PR is part of our larger effort to add first-class integrations to support LLMOps that was [presented at Airflow Summit](https://www.youtube.com/watch?v=mgA6m3ggKhs&t=4s).

This PR adds explicitly the pgvector Provider. 
https://github.com/pgvector/pgvector

Email Discussion related to the effort can be found here - https://lists.apache.org/thread/0d669fmy4hn29h5c0wj0ottdskd77ktp
@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dev-tools area:providers changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) kind:documentation use public runners Makes sure that Public runners are used even if commiters creates the PR (useful for testing)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants