Add Jira Notifier implementation

[pubudu91]

Fixes #35261

Sample usage:

from datetime import datetime
from airflow import DAG
from airflow.operators.bash import BashOperator
from airflow.providers.atlassian.jira.notifications.jira import send_jira_notification

with DAG(
    "test-dag",
    start_date=datetime(2023, 11, 3),

):
    BashOperator(
        task_id="mytask",
        on_failure_callback=[
            send_jira_notification(jira_conn_id="my-jira-conn",
            description="The task failed",
            summary="Airflow Issue 1",
            project_id=10000,
            issue_type_id=10003,
            labels=["airflow-dag-failure"]
            )
        ],
        bash_command="fail",
        retries=0
    )

---

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

[Taragolis]

In general looks good

Just need to add tests and information into the provider documentation. Another PR's for the reference:

• Add notifier for pagerduty #31207
• Add DiscordNotifier #31273
• Add ChimeNotifier #32222
• Add Slack Incoming Webhook Notifier #33966

[pubudu91]

@Taragolis Addressed the above mentioned suggestions. Still working on the tests and the docs.

[Taragolis]

Documentation should be pretty simple: copy from one of existed provider, replace by new example (you have in description of PR), change reference to the Notifier classes, build it locally by run breeze build-docs atlassian.jira and check it, see:
https://github.com/apache/airflow/blob/main/BREEZE.rst#building-the-documentation

And if you need any help you might ask the questions in the Slack channel #development-first-pr-support

[Taragolis]

Some NIT which might make it better

In general looks good, also check documentation locally

[pubudu91]

Some NIT which might make it better

In general looks good, also check documentation locally

Built and checked the new docs locally. There weren't any issues. Will check again with the suggestions applied.

[pubudu91]

Locally built docs:
index

guide

A small concern. We added a note saying the feature is only available from >=2.6.0. But in the above screenshots, in the left navigation the version says 2.2.0?

[Taragolis]

the left navigation the version says 2.2.0?

That is provider version. Providers release cycle are different then Airflow itself

[eladkal]

Shouodn't this be JiraNotifier(...) ?

[pubudu91]

All the notifiers seem to have followed this pattern. e.g.,

airflow/airflow/providers/amazon/aws/notifications/chime.py

Line 64 in ca27772

send_chime_notification = ChimeNotifier

[Taragolis]

Yeah, this pattern exists from the very first notifier.

[eladkal]

Pattern aside.. this is an example that we publish in docs so we can change it if we wish.

Isn't on_failure_callback=ChimeNotifier(...) Works the same and is more intuitive?

[pubudu91]

Pattern aside.. this is an example that we publish in docs so we can change it if we wish.

Yes, can use either approach. But then it'll look inconsistent with the existing examples in other notifier docs though. e.g., https://airflow.apache.org/docs/apache-airflow-providers-amazon/8.6.0/notifications/chime_notifier_howto_guide.html

Isn't on_failure_callback=ChimeNotifier(...) Works the same and is more intuitive?

Functionally, exactly the same. Personally for me, having an action verb in the name reads better in this context though. Like, on failure, send this notification.

[pubudu91]

A kind reminder on this. Are we good to merge?