-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix _DockerDecoratedOperator
module type attribute pickle error
#35293
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
Can you please add unit tests for it showing the case? The fact that the tests are passing before and after the change mean that we missed a test case for it. |
I want to add a test, but I don't know exactly what case I should add a test for. What I found is that when some dag define a task_dict attribute, I get an error in the part where dag run Should I add a test that runs |
a91a123
to
ab2af83
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Thanks a lot for diagnosis and fix @phi-friday !
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
@potiuk Thank you for guiding me. Have a good day. |
#35285
Changed the existing
pickling_library
attribute to property and addeduse_dill
attribute instead, as the property that_DockerDecoratedOperator
has is not serializable and causes an error in the scheduler.origin
new
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.