Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add operator to create jobs in Databricks #35156

Merged
merged 19 commits into from
Oct 27, 2023

Conversation

tatiana
Copy link
Contributor

@tatiana tatiana commented Oct 24, 2023

Add DatabricksCreateJobsOperator for use cases where the DatabricksSubmitRunOperator is insufficient.

Closes: #29733

This work was mostly done by @kyle-winkelman (#29790) and @stikkireddy (#32221), and this PR aims to get their work to the finishing line.

These were the changes I made since #32221:

  • Rebase on the main branch
  • Validate by running a real DAG that communicates with Databricks via this operator
  • Remove the databricks-sdk dependency as a follow-up to a conversation with @stikkireddy, since the interfaces of this library are not stable yet. We can improve the operator in the future to use this after the 1.0 release.
  • Validate by running a real DAG that communicates with Databricks via this operator

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@tatiana tatiana force-pushed the databricks-jobs-create branch from f75c975 to 043f692 Compare October 27, 2023 18:07
@tatiana tatiana marked this pull request as ready for review October 27, 2023 18:40
@tatiana
Copy link
Contributor Author

tatiana commented Oct 27, 2023

@Lee-W @potiuk @phanikumv @pankajastro @pankajkoti

This PR addresses the feedback given on #32221 and fixes the tests.

The databricks-sdk dependency was removed since its interfaces are not currently stable - this was agreed with the original PR author.

Hoping we can get this merged to main soon - I have a few follow up PRs!

Copy link
Member

@pankajastro pankajastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pankajastro pankajastro merged commit a8784e3 into apache:main Oct 27, 2023
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Databricks create/reset then run-now
4 participants