Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make DefaultAzureCredential in AzureBaseHook configuration #35051

Conversation

Lee-W
Copy link
Member

@Lee-W Lee-W commented Oct 19, 2023

Allow user to provide argument managed_identity_client_id and workload_identity_tenant_id to DefaultAzureCredential


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@Lee-W Lee-W changed the title feat(azure): make managed_identity configurable int base azure hook Make DefaultAzureCredential in AzureBaseHook configuration Oct 19, 2023
@Lee-W Lee-W force-pushed the make-azure-base-hook-default-credential-configurable branch 5 times, most recently from 245f855 to 26864f4 Compare October 26, 2023 08:00
@Lee-W Lee-W marked this pull request as ready for review October 26, 2023 08:04
@Lee-W Lee-W force-pushed the make-azure-base-hook-default-credential-configurable branch from 26864f4 to a122cb2 Compare October 26, 2023 08:25
@Lee-W Lee-W force-pushed the make-azure-base-hook-default-credential-configurable branch from fce0b73 to 1dc7801 Compare October 27, 2023 01:55
Copy link
Member

@hussein-awala hussein-awala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ashb ashb merged commit 2b011b2 into apache:main Oct 30, 2023
44 checks passed
@ashb ashb deleted the make-azure-base-hook-default-credential-configurable branch October 30, 2023 17:01
@melugoyal
Copy link
Contributor

@eladkal can we include this PR in #35240?

@eladkal
Copy link
Contributor

eladkal commented Oct 30, 2023

@eladkal can we include this PR in #35240?

No, it will have to wait for next provider wave

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants