Improve clear_not_launched_queued_tasks call duration #34985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:cncf-kubernetes
|
Please consider reformatting the commit message so it fits the standard style. |
dirrao
force-pushed
the
34877-clear_not_launched_queued_tasks_optimization
branch
from
72d3669 to
72f5f89
Compare
uranusjr
changed the title
uranusjr
reviewed
Oct 18, 2023
airflow/providers/cncf/kubernetes/executors/kubernetes_executor.py
Outdated
Show resolved
Hide resolved
uranusjr
reviewed
Oct 18, 2023
airflow/providers/cncf/kubernetes/executors/kubernetes_executor.py
Outdated
Show resolved
Hide resolved
uranusjr
reviewed
Oct 18, 2023
airflow/providers/cncf/kubernetes/executors/kubernetes_executor.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Tzu-ping Chung <[email protected]>
potiuk
force-pushed
the
34877-clear_not_launched_queued_tasks_optimization
branch
from
ed4ca77 to
144f9d1
Compare
There was a problem hiding this comment.
This PR will slightly increase memory usage, especially if parallelism is set to a high value, but it will have a significant positive impact on scheduling time and scheduler performance.
Overall it looks good, but I prefer to test it first, I will try to do that ASAP.
|
@hussein-awala Did you get a chance to test it? Any findings? |
hussein-awala
approved these changes
Oct 27, 2023
|
@uranusjr / @jedcunningham, |
eladkal
approved these changes
Nov 1, 2023
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
60 tasks
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Nov 10, 2023
* Improve clear_not_launched_queued_tasks call duration * Apply suggestions from code review Co-authored-by: Tzu-ping Chung <[email protected]> --------- Co-authored-by: gopal <[email protected]> Co-authored-by: Tzu-ping Chung <[email protected]> Co-authored-by: Hussein Awala <[email protected]> Co-authored-by: Elad Kalif <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Airflow running the clear_not_launched_queued_tasks function on a certain frequency (default 30 seconds). When we run the airflow on a large Kube cluster (pods more than > 5K). Internally the clear_not_launched_queued_tasks function loops through each queued task and checks the corresponding worker pod existence in the Kube cluster. Right this existence check using list pods Kube API. The API is taking more than 1s. if there are 120 queued tasks, then it will take ~ 120 seconds (1s * 120). So, this leads the scheduler to spend most of its time in this function rather than scheduling the tasks. It leads to none of the jobs being scheduled or degraded scheduler performance.
Solution: Use k8 list pods batch api call to get all the worker pod owned by scheduler. Prepare the set of searchable strings using pod labels. Use this set data structure and identify whether the task associated pod exists or not.
set elements string format:
(dag_id=<dag_id>,task_id=<task_id>,airflow-worker=[,map_index=<map_index>],[run_id=<run_id>]|[execution_date=<execution_date>])
The details for the issue is mentioned in the below ticket #34877
Closes: #34877