Fix triggerer thread crash in daemon mode #34931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the order of operations so that async child thread is created after forking when entering daemon context. This makes sure that the thread stays alive in the internal loop.
|
Also as explained in #34816 (comment), I'm willing to follow up with another contribution where all other commands are refactored to use the same pattern for daemon mode (and maybe reuse the same code?) but it needs a longer thought so I think it deserves a separate PR. |
There was a problem hiding this comment.
Interesting! I believe this would fix the issue.
Could you fix the static checks? https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst
@hussein-awala done |
potiuk
approved these changes
Oct 14, 2023
ephraimbuddy
pushed a commit
that referenced
this pull request
Oct 29, 2023
* Fixes #34816 Change the order of operations so that async child thread is created after forking when entering daemon context. This makes sure that the thread stays alive in the internal loop. --------- Co-authored-by: daniel.dylag <[email protected]> (cherry picked from commit 9c1e8c2)
ephraimbuddy
pushed a commit
that referenced
this pull request
Oct 30, 2023
* Fixes #34816 Change the order of operations so that async child thread is created after forking when entering daemon context. This makes sure that the thread stays alive in the internal loop. --------- Co-authored-by: daniel.dylag <[email protected]> (cherry picked from commit 9c1e8c2)
40 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34816
Change the order of operations so that async child thread is created after forking when entering daemon context. This makes sure that the thread stays alive in the internal loop - forking causes stopping all child threads.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.