Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dags.rst docs to put SubDag deprecation note right after the SubDag… #34925

Merged
merged 1 commit into from
Oct 14, 2023
Merged

Update dags.rst docs to put SubDag deprecation note right after the SubDag… #34925

merged 1 commit into from
Oct 14, 2023

Conversation

jayljohnson
Copy link
Contributor

@jayljohnson jayljohnson commented Oct 13, 2023 •
edited
Loading

Small doc change to save time for people by letting them know up front that SubDag feature is deprecated and TaskGroup's should be used instead.

@jayljohnson
Update dags.rst to put SubDag deprecation note right after the SubDag…
e739bc4 
… section heading

To save time for people by letting them know up front that SubDag feature is deprecated and TaskGroup's should be used instead.
@boring-cyborg
Copy link

boring-cyborg bot commented Oct 13, 2023

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

@eladkal eladkal added this to the Airflow 2.7.3 milestone Oct 14, 2023
@eladkal eladkal added the type:doc-only Changelog: Doc Only label Oct 14, 2023
@eladkal eladkal merged commit 8f93f68 into apache:main Oct 14, 2023
43 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented Oct 14, 2023

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

ephraimbuddy pushed a commit that referenced this pull request Oct 29, 2023
@jayljohnson @ephraimbuddy
Update dags.rst to put SubDag deprecation note right after the SubDag…
9262b4d 
… section heading (#34925)

To save time for people by letting them know up front that SubDag feature is deprecated and TaskGroup's should be used instead.

(cherry picked from commit 8f93f68)
ephraimbuddy pushed a commit that referenced this pull request Oct 30, 2023
@jayljohnson @ephraimbuddy
Update dags.rst to put SubDag deprecation note right after the SubDag…
6eb1048 
… section heading (#34925)

To save time for people by letting them know up front that SubDag feature is deprecated and TaskGroup's should be used instead.

(cherry picked from commit 8f93f68)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Taragolis Taragolis Taragolis approved these changes

@Lee-W Lee-W Lee-W approved these changes

@eladkal eladkal eladkal approved these changes

@potiuk potiuk Awaiting requested review from potiuk potiuk is a code owner

Assignees
No one assigned
Labels
kind:documentation type:doc-only Changelog: Doc Only
Projects
None yet
Milestone
Airflow 2.7.3
Development

Successfully merging this pull request may close these issues.
4 participants
@jayljohnson @Taragolis @Lee-W @eladkal