-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helm chart should set AIRFLOW_HOME from airflowHome #34839
Helm chart should set AIRFLOW_HOME from airflowHome #34839
Conversation
chart/templates/_helpers.yaml
Outdated
{{- if .Values.enableBuiltInSecretEnvVars.AIRFLOW__CORE__FERNET_KEY }} | ||
- name: AIRFLOW__CORE__FERNET_KEY | ||
valueFrom: | ||
secretKeyRef: | ||
name: {{ template "fernet_key_secret" . }} | ||
key: fernet-key | ||
{{- end }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You didn't mean to remove this, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
corrrrect sir my b
values={"airflowHome": exp_path}, | ||
show_only=["templates/webserver/webserver-deployment.yaml"], | ||
) | ||
assert {"name": "AIRFLOW_HOME", "value": exp_path} in jmespath.search( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be worth a test that the default is added as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good call
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 I second this
372d650
to
7c70efe
Compare
Currently if you change airflowHome from /opt/airflow to something else it doesn't totally work because the official image hardcodes the env var AIRFLOW_HOME. This should fix that.