-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Allow description to be passed in when using variables CLI #34791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having some issue with CI, resolving those issues now |
Fixed unit test errors
Will be publishing next revision in a bit |
1 task
Lee-W
approved these changes
Oct 8, 2023
Used Github UI to rebase the feature branch. |
Taragolis
reviewed
Oct 10, 2023
Taragolis
changed the title
Feature: Allow description to be passed in when uring variables CLI
Feature: Allow description to be passed in when using variables CLI
Oct 10, 2023
uranusjr
reviewed
Oct 11, 2023
uranusjr
reviewed
Oct 13, 2023
uranusjr
approved these changes
Oct 20, 2023
uranusjr
reviewed
Oct 20, 2023
Co-authored-by: Tzu-ping Chung <[email protected]>
uranusjr
approved these changes
Oct 23, 2023
eladkal
approved these changes
Oct 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
This PR closes: #34756
Testing