Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add securityContexts in dagProcessor.logGroomerSidecar #34499

Merged
merged 9 commits into from
Nov 29, 2023
Merged

Add securityContexts in dagProcessor.logGroomerSidecar #34499

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d48ab90
Include securityContexts in dag-processor-log-groomer
aldwyn Sep 20, 2023
5e62920
Add securityContexts config for dagProcessor.logGroomerSidecar
aldwyn Sep 20, 2023
f41a0fc
Merge branch 'main' into main
aldwyn Sep 20, 2023
9fbc6ca
Merge branch 'apache:main' into main
aldwyn Oct 18, 2023
3aeb345
Include dag-processor in test_log_groomer_sidecar_container_setting
aldwyn Oct 18, 2023
b691601
Merge branch 'main' into main
aldwyn Oct 22, 2023
f8798c2
Merge branch 'main' into main
eladkal Oct 31, 2023
b7b651b
Merge branch 'main' into main
aldwyn Nov 7, 2023
490606f
Merge branch 'main' into main
aldwyn Nov 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions chart/templates/dag-processor/dag-processor-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
{{- $revisionHistoryLimit := or .Values.dagProcessor.revisionHistoryLimit .Values.revisionHistoryLimit }}
{{- $securityContext := include "airflowPodSecurityContext" (list . .Values.dagProcessor) }}
{{- $containerSecurityContext := include "containerSecurityContext" (list . .Values.dagProcessor) }}
{{- $containerSecurityContextLogGroomerSidecar := include "containerSecurityContext" (list . .Values.dagProcessor.logGroomerSidecar) }}
{{- $containerSecurityContextWaitForMigrations := include "containerSecurityContext" (list . .Values.dagProcessor.waitForMigrations) }}
{{- $containerLifecycleHooks := or .Values.dagProcessor.containerLifecycleHooks .Values.containerLifecycleHooks }}
apiVersion: apps/v1
Expand Down Expand Up @@ -198,6 +199,7 @@ spec:
resources: {{- toYaml .Values.dagProcessor.logGroomerSidecar.resources | nindent 12 }}
image: {{ template "airflow_image" . }}
imagePullPolicy: {{ .Values.images.airflow.pullPolicy }}
securityContext: {{ $containerSecurityContextLogGroomerSidecar | nindent 12 }}
{{- if .Values.dagProcessor.logGroomerSidecar.command }}
command: {{ tpl (toYaml .Values.dagProcessor.logGroomerSidecar.command) . | nindent 12 }}
{{- end }}
Expand Down
2 changes: 2 additions & 0 deletions chart/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1666,6 +1666,8 @@ dagProcessor:
# requests:
# cpu: 100m
# memory: 128Mi
securityContexts:
container: {}

waitForMigrations:
# Whether to create init container to wait for db migrations
Expand Down
2 changes: 2 additions & 0 deletions helm_tests/security/test_security_context.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,10 +322,12 @@ def test_log_groomer_sidecar_container_setting(self):
values={
"scheduler": {**spec},
"workers": {**spec},
"dagProcessor": {**spec},
},
show_only=[
"templates/scheduler/scheduler-deployment.yaml",
"templates/workers/worker-deployment.yaml",
"templates/dag-processor/dag-processor-deployment.yaml",
],
)

Expand Down