Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bad advice from Kafka system tests #34470

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

Taragolis
Copy link
Contributor

related: #34469


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Copy link
Member

@hussein-awala hussein-awala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be possible when we add support for multi-events in the triggers, but currently I agree that this example is too bad, the users should process the messages outside Airflow and trigger the dag runs via the REST API.

@hussein-awala hussein-awala merged commit 404666d into apache:main Sep 25, 2023
@Taragolis Taragolis deleted the remove-bad-advice-kafka branch September 25, 2023 18:32
@Taragolis Taragolis added the type:doc-only Changelog: Doc Only label Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants