Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add distinct function to MongoHook in apache-airflow-providers-mongo #34466

Merged
merged 8 commits into from
Oct 25, 2023

Conversation

octaviolage
Copy link
Contributor


This PR adds a distinct() function to the MongoHook in apache-airflow-providers-mongo, which reffers pymongo.collection.distinct. This function allows users to return a list of distinct values from a MongoDB collection. I think the distinct function fits well with the other collection functions in the hook.

Before:

hook = MongoHook(conn_id='my_conn_id')
coll = hook.get_collection(
                mongo_db='test',
                mongo_collection='test',
            )
distinct_keys = coll.distinct('name')

After:

hook = MongoHook(conn_id='my_conn_id')
distinct_keys= hook.get_collection(
                mongo_db='test',
                mongo_collection='test',
                key='name'
            )

@boring-cyborg
Copy link

boring-cyborg bot commented Sep 19, 2023

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

airflow/providers/mongo/hooks/mongo.py Outdated Show resolved Hide resolved
airflow/providers/mongo/hooks/mongo.py Outdated Show resolved Hide resolved
@octaviolage octaviolage requested a review from Lee-W September 19, 2023 18:59
@vincbeck
Copy link
Contributor

There are some test failures. Please run static checks and also check the unit test you wrote, it is failing.

@vincbeck
Copy link
Contributor

There are still some static checks failures. You should be able to fix them automatically by looking at documentation

@vincbeck vincbeck merged commit 647e767 into apache:main Oct 25, 2023
44 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented Oct 25, 2023

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants