Fix parsing KubernetesPodOperator multiline logs #34412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:cncf-kubernetes
|
I will add some tests before marking it as ready for review |
eladkal
approved these changes
Oct 1, 2023
|
@hussein-awala can you fix conflicts and rebase? |
I was working on it, it should be fine now |
98 tasks
|
When will this fix be available in helm stable? |
|
@hussein-awala i was trying to understand this a bit more. but i was unable to actually produce multiline logs in KPO. can you tell me how i can reproduce the multiline log behavior? |
2 tasks
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #34388
related: #21605
This PR combines the multi-line log messages read from KubernetesPodOperator pod before logging them by the task.
Why removing the logged error messages is not enough?
In case of any interruption, we retry the method, so if we are in the middle of a multi-line message, we could have a duplication in the log because all the lines after the first one do not have a timestamp, but by combining them in the same message before logging them, we ensure in case of any interruption that we will retry combining and logging the whole message because we didn't do that in the first retry.