Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add containerSecurityContext for cleanup cronjob #34351

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Add containerSecurityContext for cleanup cronjob #34351

merged 1 commit into from
Sep 13, 2023

Conversation

kimminw00
Copy link
Contributor

@kimminw00 kimminw00 commented Sep 13, 2023 •
edited
Loading

Fixes #34298

Add containerSecurityContext in airflow/chart/templates/cleanup/cleanup-cronjob.yaml.

@boring-cyborg boring-cyborg bot added the area:helm-chart Airflow Helm Chart label Sep 13, 2023
hussein-awala
hussein-awala approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@hussein-awala hussein-awala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, it seems like the value was added but never used. LGTM

@potiuk potiuk merged commit 847d2c3 into apache:main Sep 13, 2023
52 checks passed
@jedcunningham jedcunningham mentioned this pull request Sep 27, 2023
Closed
24 tasks
@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@potiuk potiuk potiuk approved these changes

@hussein-awala hussein-awala hussein-awala approved these changes

@dstandish dstandish Awaiting requested review from dstandish dstandish is a code owner

@jedcunningham jedcunningham Awaiting requested review from jedcunningham jedcunningham is a code owner

Assignees
No one assigned
Labels
area:helm-chart Airflow Helm Chart changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

securityContext value for the cleanup container is not set properly
4 participants
@kimminw00 @potiuk @hussein-awala @ephraimbuddy