-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Differentiate 0 and unset as a default param values #33965
Merged
hussein-awala
merged 1 commit into
apache:main
from
SamWheating:sw-fix-default-values-in-params-form
Aug 31, 2023
Merged
Differentiate 0 and unset as a default param values #33965
hussein-awala
merged 1 commit into
apache:main
from
SamWheating:sw-fix-default-values-in-params-form
Aug 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamWheating
requested review from
ryanahamilton,
ashb,
bbovenzi and
pierrejeambrun
as code owners
August 31, 2023 17:06
boring-cyborg
bot
added
area:UI
Related to UI/UX. For Frontend Developers.
area:webserver
Webserver related Issues
labels
Aug 31, 2023
potiuk
approved these changes
Aug 31, 2023
Nice. Thanks Again @SamWheating . You are our 2.7.0 bug-squasher. |
Taragolis
approved these changes
Aug 31, 2023
pierrejeambrun
approved these changes
Aug 31, 2023
jscheffl
approved these changes
Aug 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking about using {% if form_details.value is number %}
but checking against not none is also good :-D
Thanks for the quick solution @SamWheating, much appreciated 🙏 |
hussein-awala
approved these changes
Aug 31, 2023
2 tasks
ephraimbuddy
pushed a commit
that referenced
this pull request
Sep 1, 2023
(cherry picked from commit c51901a)
97 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:UI
Related to UI/UX. For Frontend Developers.
area:webserver
Webserver related Issues
type:bug-fix
Changelog: Bug Fixes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #33923
Pretty self explanatory, since python's zero is falsey, using
{% if form.details.value %}
led to the default value being omitted if it was a zero. This minor change makes a zero default value explicitly zero, and if a user wants to default to null they can use something like:So given the following DAG:
This was the default form before:
And this is it after:
List-type params are a whole different problem, and there's a lot of discussion in the original issue, so lets leave that for another PR? In the current implementation there's no way to explicitly pass an empty list through the form interface so I think that some changes will be definitely be required.