Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove version top-level element from docker compose files #33831

Merged
merged 2 commits into from
Aug 30, 2023

Conversation

Taragolis
Copy link
Contributor

This is optional field since compose 1.27. We use internally compose v2, so I do not see viable reason to keep it.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@@ -44,7 +44,6 @@
#
# Feel free to modify this file to suit your needs.
---
version: '3.8'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One potential exception it is keep only for docker-compose from documentation

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From https://docs.docker.com/compose/history/

From July 2023 Compose V1 stopped receiving updates. It's also no longer available in new releases of Docker Desktop.

I think it's time we drop compose v1 compatibility also from the documentation one. I think we should just add information in https://airflow.apache.org/docs/apache-airflow/stable/howto/docker-compose/index.html that Only docker compose v2 is supported.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

People always can download old compose from previous Airflow versions.

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending the docs update mentioning docker v2-only compatibility.

@Taragolis Taragolis force-pushed the remove-docker-compose-version branch from 59f81b4 to 8fe08ad Compare August 30, 2023 19:34
@potiuk potiuk merged commit 32a490e into apache:main Aug 30, 2023
64 checks passed
@@ -35,7 +35,7 @@ This procedure assumes familiarity with Docker and Docker Compose. If you haven'
Follow these steps to install the necessary tools, if you have not already done so.

1. Install `Docker Community Edition (CE) <https://docs.docker.com/engine/installation/>`__ on your workstation. Depending on your OS, you may need to configure Docker to use at least 4.00 GB of memory for the Airflow containers to run properly. Please refer to the Resources section in the `Docker for Windows <https://docs.docker.com/docker-for-windows/#resources>`__ or `Docker for Mac <https://docs.docker.com/docker-for-mac/#resources>`__ documentation for more information.
2. Install `Docker Compose <https://docs.docker.com/compose/install/>`__ v1.29.1 or newer on your workstation.
2. Install `Docker Compose <https://docs.docker.com/compose/install/>`__ v2.14.0 or newer on your workstation.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't come up with anything better here rather than pick up current MIN_DOCKER_COMPOSE_VERSION for CI/Breeze 🤣 At least we run compose tests by use 2.14

Copy link
Member

@potiuk potiuk Aug 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a very good one. I even explained that very minimum is coming in this PR today to a user in Slack

@Taragolis Taragolis deleted the remove-docker-compose-version branch August 30, 2023 21:28
@ephraimbuddy ephraimbuddy added this to the Airflow 2.8.0 milestone Oct 3, 2023
@ephraimbuddy ephraimbuddy added the type:improvement Changelog: Improvements label Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants