Fix MappedTaskGroup tasks not respecting upstream dependency #33732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ephraimbuddy
force-pushed
the
fix-mapped-tg-upstream
branch
from
d87db9c
to
4ac2e41
Compare
uranusjr
reviewed
Aug 29, 2023
ephraimbuddy
force-pushed
the
fix-mapped-tg-upstream
branch
from
40d0c91
to
45851e6
Compare
When a MappedTaskGroup has upstream dependencies, the tasks in the group don't wait for the upstream tasks before they start running, this causes the tasks to fail. From my investigation, the tasks inside the MappedTaskGroup don't have upstream tasks while the MappedTaskGroup has the upstream tasks properly set. Due to this, the task's dependencies are met even though the Group has upstreams that haven't finished. The Fix was to set upstreams after creating the task group with the factory Closes: apache#33446
ephraimbuddy
force-pushed
the
fix-mapped-tg-upstream
branch
from
45851e6
to
7a5b6ee
Compare
uranusjr
approved these changes
Aug 29, 2023
ephraimbuddy
added a commit
that referenced
this pull request
Sep 1, 2023
* Fix MappedTaskGroup tasks not respecting upstream dependency When a MappedTaskGroup has upstream dependencies, the tasks in the group don't wait for the upstream tasks before they start running, this causes the tasks to fail. From my investigation, the tasks inside the MappedTaskGroup don't have upstream tasks while the MappedTaskGroup has the upstream tasks properly set. Due to this, the task's dependencies are met even though the Group has upstreams that haven't finished. The Fix was to set upstreams after creating the task group with the factory Closes: #33446 * set the relationship in __exit__ (cherry picked from commit fe27031)
2 tasks
97 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a MappedTaskGroup has upstream dependencies, the tasks in the group don't wait for the upstream tasks
before they start running, this causes the tasks to fail.
From my investigation, the tasks inside the MappedTaskGroup don't have upstream tasks while the
MappedTaskGroup has the upstream tasks properly set. Due to this, the task's dependencies are met even though the Group has
upstreams that haven't finished.
The Fix was to set upstreams after creating the task group with the factory
Closes: #33446