Upgrade botocore/aiobotocore minimum requirements #33649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
added
the
full tests needed
|
Applied full tests needed to build for all Python versions. Let's see if the help given to |
potiuk
commented
Aug 23, 2023
Taragolis
reviewed
Aug 23, 2023
Taragolis
approved these changes
Aug 23, 2023
eladkal
approved these changes
Aug 23, 2023
potiuk
force-pushed
the
upgrade-botocore-requirements
branch
from
7608926
to
820af9c
Compare
pankajastro
approved these changes
Aug 23, 2023
Lee-W
approved these changes
Aug 23, 2023
|
ok. I think i will need to add a little "trick" for "pypi" providers to also help |
Botocore has a very peculiar process of releasing new version every day, which means that it gives `pip` hard time to figure what will be the non-conflicting set of packages when we have too low of a minium version set as requirement. Since we had > 1.24 that means that `pip` had to consider more than 340 versions for botocore, but also for related mypy packages and also a number of aiobotocore packages when resolving eager-upgrade. We limit all the relevant packages to 1.28 as minimum version now, and we should continue doing that regularly in the future.
potiuk
force-pushed
the
upgrade-botocore-requirements
branch
from
820af9c
to
b20bdb0
Compare
|
All right - so fix for constraints was easy - the root cause was yandex we just resumed. I have to temporary disable it until we release it. |
potiuk
added a commit
that referenced
this pull request
Aug 25, 2023
Botocore has a very peculiar process of releasing new version every day, which means that it gives `pip` hard time to figure what will be the non-conflicting set of packages when we have too low of a minium version set as requirement. Since we had > 1.24 that means that `pip` had to consider more than 340 versions for botocore, but also for related mypy packages and also a number of aiobotocore packages when resolving eager-upgrade. We limit all the relevant packages to 1.28 as minimum version now, and we should continue doing that regularly in the future. (cherry picked from commit 5f504e9)
63 tasks
97 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Botocore has a very peculiar process of releasing new version every day, which means that it gives
piphard time to figure what will be the non-conflicting set of packages when we have too low of a minium version set as requirement.Since we had > 1.24 that means that
piphad to consider more than 340 versions for botocore, but also for related mypy packages and also a number of aiobotocore packages when resolving eager-upgrade.We limit all the relevant packages to 1.28 as minimum version now, and we should continue doing that regularly in the future.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.