Chart: pass workers.terminationGracePeriodSeconds into KubeExecutor pod template #33514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamWheating
requested review from
dstandish,
jedcunningham and
hussein-awala
as code owners
|
Yep, no need for a new value. Can you add a test here? |
SamWheating
force-pushed
the
sw-graceful-termination-kube-executor
branch
from
39f48ad
to
a5b0e08
Compare
jedcunningham
approved these changes
Aug 19, 2023
ephraimbuddy
added
the
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the chart allows users to specify a custom TerminationGracePeriodSeconds for the celery workers, this value is not passed into the Kubernetes Executor pod template, and thus pods use the default 30s timeout.
It seems like the
workers:section of the values is applied to both the Celery worker pods as well as the default KubeExecutor pods so I figured there was no need to define a new value. Thoughts?