Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove openlineage exclusion #33491

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Aug 18, 2023

Now that Airflow 2.7.0 is released, we can remove exclusion that we had for openlineage which prevented from using it as dependency of Airflow in CI.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@potiuk
Copy link
Member Author

potiuk commented Aug 18, 2023

We need to solve a bit chicken-egg problem with this one for >= 2.7.0 in openlinage provider.

For the record - this is the sequence that should work:

  • Release 2.7.0 in PyPI (done)
  • Tag constraints with constraints-2.7.0 in constraints-2-7 (in-progrees)
  • Build image for 2.7.0 in Dockerhub (in-progrees)
  • Update Airlfow version to 2.8.0.dev0 in main
  • Rebase + Merge this one to main
  • Cherry-pick this one to v2-7-test
  • move constraints-2.7.0 tag for constraints after updated constraints are pushed to constraints-2-7
  • rebuild image for 2.7.0 in Dockerhub

One time process to go through (cc: @ephraimbuddy )

@potiuk potiuk closed this Aug 18, 2023
@potiuk potiuk reopened this Aug 18, 2023
Now that Airflow 2.7.0 is released, we can remove exclusion that
we had for openlineage which prevented from using it as
dependency of Airflow in CI.
@potiuk potiuk force-pushed the remove-exclusion-for-openlineage branch from 645c874 to 6f46457 Compare August 18, 2023 12:40
@potiuk
Copy link
Member Author

potiuk commented Aug 18, 2023

This one failed, but I looked at it and it only failed because we run it from PR and it missed the "openlineage" provider in "installed_providers.txt" - this will get fixed automatically after merging to main. Merging.

@potiuk potiuk merged commit 008f233 into apache:main Aug 18, 2023
57 of 59 checks passed
@potiuk potiuk deleted the remove-exclusion-for-openlineage branch August 18, 2023 13:28
potiuk added a commit that referenced this pull request Aug 18, 2023
Now that Airflow 2.7.0 is released, we can remove exclusion that
we had for openlineage which prevented from using it as
dependency of Airflow in CI.

(cherry picked from commit 008f233)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants