Use absolute path in README.md for broken links on PyPI listing #33473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Observed a couple of links are broken on our pypi project listing https://pypi.org/project/apache-airflow/. They work fine when viewed on GitHub but those relative links don't work fine on the pypi index. Also, applied a few quick-fixes that my PyCharm suggested for the README.md file
pankajkoti
force-pushed
the
fix-readme-links-for-pypi
branch
from
fb94acd
to
3e08a40
Compare
pankajkoti
added
the
changelog:skip
potiuk
approved these changes
Aug 17, 2023
|
Cool, Thanks! |
ephraimbuddy
pushed a commit
that referenced
this pull request
Aug 28, 2023
Observed a couple of links are broken on our pypi project listing https://pypi.org/project/apache-airflow/. They work fine when viewed on GitHub but those relative links don't work fine on the pypi index. Also, applied a few quick-fixes that my PyCharm suggested for the README.md file (cherry picked from commit 5a37025)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Observed a couple of links are broken on our PyPI project listing
https://pypi.org/project/apache-airflow/. They work fine when
viewed on GitHub but those relative links don't work fine on the
PyPI index. Also, applied a few quick fixes that my PyCharm
suggested for the README.md file
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.