Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the replace to <br> tag in Provider's view #33326

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

pankajkoti
Copy link
Member

As seen in the issue the description value has a trailing
slash. Since this element value is part of a table row-column
value tag, essentially we do not need to remove the
trailing new line characters and as seen in the issue
the template is not respecting the
tag well.
The PR removes the replace of new line to br tag to fix
the issue.

closes: #33325


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added the area:webserver Webserver related Issues label Aug 11, 2023
@pankajkoti
Copy link
Member Author

After the fix:

Screenshot 2023-08-12 at 12 54 45 AM

@pankajkoti pankajkoti marked this pull request as ready for review August 11, 2023 20:00
@hussein-awala hussein-awala merged commit 23d5424 into apache:main Aug 11, 2023
42 checks passed
@hussein-awala hussein-awala added the type:bug-fix Changelog: Bug Fixes label Aug 11, 2023
@hussein-awala hussein-awala added this to the Airflow 2.7.1 milestone Aug 11, 2023
ferruzzi pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Aug 17, 2023
@jedcunningham jedcunningham deleted the remove-br-tag branch August 24, 2023 18:58
ephraimbuddy pushed a commit that referenced this pull request Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:webserver Webserver related Issues type:bug-fix Changelog: Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

providers view shows description with HTML element
3 participants