Add a utility to safely join URLs using urllib.parse.urljoin #33062
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working with
log_url
property of the task instances,it is observed that
urljoin
ignores the part of the path afterthe last slash specified in the base_url when it does not end
with a trailing slash and Airflow webserver does not allow
setting the base_url with a trailing slash. Additionally, it is also
observed that if the relative URL has a leading slash,
urljoin
just ingores the base URL and returns the relative URL.
Hence, we add a new utlity method
safe_urljoin
to handlethese cases.
closes: #32996
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.