Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate SqoopHook connection string and disable extra options from public hook methods #33039

Merged
merged 4 commits into from
Aug 3, 2023
Merged

Validate SqoopHook connection string and disable extra options from public hook methods #33039

merged 4 commits into from
Aug 3, 2023

Commits on Aug 3, 2023

  1. Validate SqoopHook connection string and disable extra options from h… 

    …ook methods

Check that the connection string constructed using the connection's
`host`, `port` and `schema` does not contain query params as it is not
intended. Additionally, also disable the `extra_import_options` and
`extra_export_options` arguments accepted directly by the hook
methods but accept it as a param via the hook constructor when
initialising the hook or by passing it in hook_params when initialising
the hook from operators.
    @pankajkoti
    pankajkoti committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    4d6254a View commit details
    Browse the repository at this point in the history

  2. Propogate missing hook param changes to the operator

    @pankajkoti
    pankajkoti committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    1251748 View commit details
    Browse the repository at this point in the history

  3. Remove test for invalid port with query param as ports are integers a… 

    …nd not accepted by databases
    @pankajkoti
    pankajkoti committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    405cb3d View commit details
    Browse the repository at this point in the history

  4. Add 4.0.0 to provider.yaml

    @pankajkoti
    pankajkoti committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    7988831 View commit details
    Browse the repository at this point in the history