Add more explicit "embedded postgres" exclusion for production #33034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:dev-tools
area:helm-chart
Our language that warned about not using the embedded postgres for production in our Helm Chart was not strong enough. It only "advised" to use external database, but really the embedded Postgres lacks all the the things that you need when you want to make sure your production deployment is "safe" - persistency, monitoring, backup, upgrade scenarios are all missing. I think we should be much stronger in saying "data loss might occur" "you SHOULD NOT" use it for production. This is much more realistic warning and it makes it easier for us to direct users who have problems with embedded postgres to use "real" database for production.
potiuk
force-pushed
the
more-explicit-embedded-postgres-warning
branch
from
7288277
to
a89abce
Compare
potiuk
changed the title
eladkal
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our language that warned about not using the embedded postgres for
production in our Helm Chart was not strong enough. It only "advised"
to use external database, but really the embedded Postgres lacks
all the the things that you need when you want to make sure your
production deployment is "safe" - persistency, monitoring, backup,
upgrade scenarios are all missing.
I think we should be much stronger in saying "data loss might occur"
"you SHOULD NOT" use it for production. This is much more realistic
warning and it makes it easier for us to direct users who have
problems with embedded postgres to use "real" database for production.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.