Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor account_url use in WasbHook #32980

Merged
merged 2 commits into from
Aug 2, 2023
Merged

Refactor account_url use in WasbHook #32980

merged 2 commits into from
Aug 2, 2023

Commits on Aug 1, 2023

  1. Refactor account_url use in WasbHook 

    This PR moves the account_url setting to one place.
Tested this by making connection to azure using the different methods, however, I was not able to connect using
the tenant_id in the extra field. This looks like a bug because ClientSecretCredential is not among the credentials
to use in BlobServiceClient. The credentials to use include AzureNamedKeyCredential,AzureSasCredential,AsyncTokenCredential.
So this will need special debugging.
    @ephraimbuddy
    ephraimbuddy committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    51dedd6 View commit details
    Browse the repository at this point in the history

  2. fixup! Refactor account_url use in WasbHook

    @ephraimbuddy
    ephraimbuddy committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    0966636 View commit details
    Browse the repository at this point in the history