Validate conn_prefix in extra field for Spark JDBC hook #32946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `conn_prefix` in `extras` should not contain a `?` as that is usually meant for appending query params to the URL and `query_params` are not the intended to be included in the `conn_prefix` section of the `extras`.
pankajkoti
force-pushed
the
sanitise-spark-connection
branch
from
a22f882
to
8f46e4d
Compare
potiuk
approved these changes
Jul 30, 2023
Lee-W
approved these changes
Jul 31, 2023
potiuk
approved these changes
Jul 31, 2023
44 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
conn_prefixinextrasshould not contain a?asthat is usually meant for appending query params to the
URL and
query_paramsare not the intended to be includedin the
conn_prefixsection of theextras.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.