-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add termination_message_policy
parameter to KubernetesPodOperator
#32885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow setting termination_message_policy in the Pod container
boring-cyborg
bot
added
provider:cncf-kubernetes
Kubernetes provider related issues
area:providers
labels
Jul 27, 2023
amoghrajesh
reviewed
Jul 27, 2023
Not sure if the failing test is a blip or not. How can I rerun the tests? |
You can re run by closing and reopening the pull request or by rebasing the PR |
hussein-awala
approved these changes
Jul 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! LGTM
Co-authored-by: Hussein Awala <[email protected]>
eladkal
changed the title
KubernetesPodOperator: add termination_message_policy option
Add Jul 29, 2023
termination_message_policy
parameter to KubernetesPodOperator
69 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow setting termination_message_policy in the Pod container.
My use case is being able to set the value of termination_message_policy to FallbackToLogsOnError.
(https://airflow.apache.org/docs/apache-airflow-providers-cncf-kubernetes/stable/operators.html#include-error-message-in-email-alert)
From Pod specification:
terminationMessagePolicy (string)
Indicate how the termination message should be populated. File will use the contents of terminationMessagePath to populate the container status message on both success and failure. FallbackToLogsOnError will use the last chunk of container log output if the termination message file is empty and the container exited with an error. The log output is limited to 2048 bytes or 80 lines, whichever is smaller. Defaults to File. Cannot be updated.