Replace Ruff's known-third-party setting with namespace-packages
#32873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
requested review from
potiuk,
ashb and
jedcunningham
as code owners
boring-cyborg
bot
added
area:dev-tools
area:providers
provider:openlineage
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
charliermarsh
commented
Jul 27, 2023
| @@ -21,9 +21,10 @@ | |||
| from typing import Any, Iterable | |||
|
|
|||
| import apprise | |||
| from airflow.hooks.base import BaseHook | |||
| from apprise import AppriseConfig, NotifyFormat, NotifyType | |||
There was a problem hiding this comment.
As an example: these apprise imports were incorrectly marked as first-party, since apprise was missing from the known-third-party.
jedcunningham
approved these changes
Jul 27, 2023
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Jul 27, 2023
The apache#32873 has been merged without merging and commiting breeze's hash accounting for changed dependencies, breaking unit tests of breeze. This PR brings hash of breeze back adter running `breeze setup version` manually and commiting the changed hash.
potiuk
added a commit
that referenced
this pull request
Jul 27, 2023
The #32873 has been merged without merging and commiting breeze's hash accounting for changed dependencies, breaking unit tests of breeze. This PR brings hash of breeze back adter running `breeze setup version` manually and commiting the changed hash.
69 tasks
ephraimbuddy
added
the
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 This PR removes the
known-third-partyandknown-first-partysettings from Airflow's Ruff configuration with a singlenamespace-packagesentry.Previously, all subdirectories of
airflow/providerswere enumerated in thepyproject.toml, but it looks like a few were added to the codebase over time but not to the list inpyproject.toml, leading to some import-categorization drift (as visible in the below changes).Ruff allows for namespace packages to be enumerated directly, which will ensure that future packages are handled consistently without any need to update the
pyproject.toml.