Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Amazon EventBridge PutRule hook and operator #32869

Merged
merged 7 commits into from
Jul 31, 2023
Merged

Add Amazon EventBridge PutRule hook and operator #32869

merged 7 commits into from
Jul 31, 2023

Conversation

mahammi
Copy link
Contributor

@mahammi mahammi commented Jul 26, 2023

Implementation for Amazon EventBridge PutRule hook and operator.

ferruzzi
ferruzzi reviewed Jul 26, 2023
View reviewed changes
Copy link
Contributor

@ferruzzi ferruzzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid start. Needs a small fix in the system test and left a couple of additional non-blocking thoughts.

airflow/providers/amazon/aws/hooks/eventbridge.py Outdated Show resolved Hide resolved
tests/providers/amazon/aws/operators/test_eventbridge.py Outdated Show resolved Hide resolved
tests/system/providers/amazon/aws/example_eventbridge.py Show resolved Hide resolved
ferruzzi
ferruzzi reviewed Jul 28, 2023
View reviewed changes
airflow/providers/amazon/aws/operators/eventbridge.py Outdated
@@ -32,6 +32,10 @@ class EventBridgePutEventsOperator(BaseOperator):
"""
Put Events onto Amazon EventBridge.

.. seealso::
For more information on how to use this operator, take a look at the guide:
:ref:`howto/operator: EventBridgePutEventsOperator`
Copy link
Contributor

@ferruzzi ferruzzi Jul 28, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try this here and in the rst:

Suggested change
:ref:`howto/operator: EventBridgePutEventsOperator`
:ref:`howto/operator:EventBridgePutEventsOperator`

ferruzzi
ferruzzi approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@ferruzzi ferruzzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work.

@mahammi mahammi requested a review from vincbeck July 28, 2023 23:28
vincbeck
vincbeck approved these changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@vincbeck vincbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR! LGTM (besides Elad's comment which I agree with)

@ferruzzi
Copy link
Contributor

ferruzzi commented Jul 31, 2023 •
edited
Loading

The method you renamed didn't get changed in some tests.

@vincbeck vincbeck merged commit 196d336 into apache:main Jul 31, 2023
42 checks passed
@vincbeck vincbeck deleted the maahaam/eventbridge_put_rule_operator branch July 31, 2023 18:55
@eladkal eladkal mentioned this pull request Aug 4, 2023
Closed
44 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eladkal eladkal eladkal left review comments

@vincbeck vincbeck vincbeck approved these changes

@ferruzzi ferruzzi ferruzzi approved these changes

@o-nikolas o-nikolas Awaiting requested review from o-nikolas o-nikolas is a code owner

Assignees
No one assigned
Labels
area:providers area:system-tests kind:documentation provider:amazon-aws AWS/Amazon - related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mahammi @ferruzzi @eladkal @vincbeck