Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the watcher resource version in SparkK8SOp when it's too old #32768

Merged
merged 1 commit into from
Jul 22, 2023

Conversation

hussein-awala
Copy link
Member

closes: #32744

This PR updates the resource version used in the Events watcher of the SparkKubernetesOperator when it is too old.
I have tested this solution before with KuberenetesExecutor and it solved the issue (#30425).


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@hussein-awala hussein-awala added the type:bug-fix Changelog: Bug Fixes label Jul 22, 2023
@boring-cyborg boring-cyborg bot added provider:cncf-kubernetes Kubernetes provider related issues area:providers labels Jul 22, 2023
@hussein-awala
Copy link
Member Author

It's difficult to reproduce the problem in a unit test, and using mocks to fake it makes the test completely useless, for that no need to add a test

@eladkal eladkal removed the type:bug-fix Changelog: Bug Fixes label Jul 22, 2023
@eladkal
Copy link
Contributor

eladkal commented Jul 22, 2023

(no need for type labels with provider changes)

@hussein-awala
Copy link
Member Author

(no need for type labels with provider changes)

Ah good to know, although it helps when creating the changelog.

@hussein-awala hussein-awala merged commit fcc6f28 into apache:main Jul 22, 2023
@cw-pradyumna
Copy link

cw-pradyumna commented Jul 22, 2023

Hi, I think line 141 should be changed in a similar way, I can make a PR for the same. Also, thank you for the quick resolution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:cncf-kubernetes Kubernetes provider related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting 410 from spark_kubernetes_operator when a task runs for long
3 participants